Skip to content

fix: reject permission requests immediately in non-interactive mode#20832

Open
rdar-lab wants to merge 1 commit intoanomalyco:devfrom
rdar-lab:bugfix/permission_check_github_aciton
Open

fix: reject permission requests immediately in non-interactive mode#20832
rdar-lab wants to merge 1 commit intoanomalyco:devfrom
rdar-lab:bugfix/permission_check_github_aciton

Conversation

@rdar-lab
Copy link
Copy Markdown

@rdar-lab rdar-lab commented Apr 3, 2026

Issue for this PR

Closes #20823

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This is a critical fix. Permission verification messages cause the github action to hang

How did you verify your code works?

Detect non-interactive mode, and deny any permisssion request that cannot be auto-approved

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@rdar-lab rdar-lab force-pushed the bugfix/permission_check_github_aciton branch from dd52710 to ef56b77 Compare April 3, 2026 07:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found several related PRs that address similar issues with permission handling in non-interactive mode:

Related PRs:

  1. fix: filter question tool and auto-approve permissions in non-interactive mode #14607 - "fix: filter question tool and auto-approve permissions in non-interactive mode"

    • Directly related: handles auto-approval of permissions in non-interactive mode

  2. fix(run): prevent subagent question tool hang in non-interactive mode #13974 - "fix(run): prevent subagent question tool hang in non-interactive mode"

  3. fix(github): auto-deny permissions and emit events in non-interactive mode #6832 - "fix(github): auto-deny permissions and emit events in non-interactive mode"

    • Related: handles denying permissions in non-interactive mode

  4. feat(tui): add auto-accept mode for permission requests #12633 - "feat(tui): add auto-accept mode for permission requests"

    • Related: deals with permission request handling modes

These PRs all relate to permission handling in non-interactive contexts, which is the core issue being addressed in PR #20832. PR #14607 and #6832 are particularly relevant as they handle permission rejection/denial in non-interactive mode scenarios.

@github-actions github-actions bot mentioned this pull request Apr 3, 2026
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Critical: Permission request notification causes github action to hang

1 participant

@rdar-lab